Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request.SetTimeout #1415

Merged
merged 3 commits into from Nov 3, 2022
Merged

Conversation

brian-armstrong-discord
Copy link
Contributor

This functionally works the same as e.g. Client.DoTimeout(), but we can also use it for Client.DoRedirect(). There is no way as far as I can tell to set a timeout on a DoRedirect call, so this makes it possible.

This functionally works the same as e.g. Client.DoTimeout(), but we can
also use it for Client.DoRedirect(). There is no way as far as I can
tell to set a timeout on a DoRedirect call, so this makes it possible.
@li-jin-gou
Copy link
Contributor

Can you add some tests to test the behavior you would expect from this function and some comment?

@brian-armstrong-discord
Copy link
Contributor Author

@li-jin-gou Thanks for the feedback! I've added some tests both for the feature in isolation (in client.Do()) and in the context of Redirects. It looks to be working as expected.

@erikdubbelboer erikdubbelboer merged commit f095481 into valyala:master Nov 3, 2022
14 checks passed
@erikdubbelboer
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants