Repository navigation
fix: lenient chunk extension parsing leading to request smuggling issues - #1899
Merged
Merged
Conversation
Collaborator
|
Can you fix the lint issue? |
Contributor
Author
|
Should be okay now, can you rerun the workflows? |
Collaborator
|
Thanks! |
|
This looks like it fixed a legitimate security vulnerability. Shouldn't a CVE be assigned? Would the fasthttp be willing to facilitate this? @erikdubbelboer Would you be willing to open a GitHub security advisory here? https://github.com/valyala/fasthttp/security Issue tracking for CVE assignment: JLLeitschuh/unCVEed#1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fasthttp allows newlines (\n) between the chunk size and the CRLF (i.e. in the chunk extension). This can cause request smuggling issues with some reverse proxies. This PR prevents this potential vulnerability by disallowing newlines in the chunk extension.
I've also corrected two unescaped carriage returns in error messages which messed with the output formatting.