New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkipBody is propagated to Response copy #532

Merged
merged 1 commit into from Feb 6, 2019

Conversation

Projects
None yet
4 participants
@enchantner
Copy link
Contributor

enchantner commented Feb 5, 2019

Addressing #529 , shouldn't break anything.

@kirillDanshin kirillDanshin merged commit 71e7652 into valyala:master Feb 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xuecai

This comment has been minimized.

Copy link
Contributor

xuecai commented Feb 11, 2019

@kirillDanshin @enchantner
resp.Reset() used in func doNonNilReqResp in client.go, it will reset SkipBody which seted by Custom.
resp is no need to reset in doNonNilReqResp ?

@erikdubbelboer

This comment has been minimized.

Copy link
Collaborator

erikdubbelboer commented Feb 11, 2019

What do you mean by "Custom"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment