Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing fixes #564

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@erikdubbelboer
Copy link
Collaborator

erikdubbelboer commented Apr 15, 2019

  • Improved timing code to be much cleaner
  • Add IdleTimeout
  • Remove obsolete optimization (was fixed in Go 2 years ago: golang/go#15133 (comment))

Fixes #563 and potentially #491

@erikdubbelboer

This comment has been minimized.

Copy link
Collaborator Author

erikdubbelboer commented Apr 15, 2019

@kirillDanshin what do you think about this? I have been testing this in a high RPS environment for some days now and it performs really well.

Show resolved Hide resolved server.go Outdated
Show resolved Hide resolved server.go Outdated

@erikdubbelboer erikdubbelboer force-pushed the timing-fixes branch from 1e66f6b to ffef72d Apr 16, 2019

@erikdubbelboer erikdubbelboer requested a review from kirillDanshin Apr 16, 2019

@erikdubbelboer erikdubbelboer force-pushed the timing-fixes branch from ffef72d to 9629844 Apr 16, 2019

Timing fixes
- Improved timing code to be much cleaner
- Add IdleTimeout
- Remove obsolete optimization (was fixed in Go 2 years ago: golang/go#15133 (comment))

@erikdubbelboer erikdubbelboer force-pushed the timing-fixes branch from 9629844 to 3bfa86f Apr 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.