Fails on GAE because of "unsafe" import #3

Closed
etnbrd opened this Issue Jan 16, 2017 · 6 comments

Comments

Projects
None yet
6 participants
@etnbrd

etnbrd commented Jan 16, 2017

fasttemplate is used by echo, a web framework, for its logger.
I currently use echo on Google App Engine, and it throws the following error :

2017/01/16 16:08:42 go-app-builder: Failed parsing input: parser: bad import "unsafe" in github.com/valyala/fasttemplate/template.go from GOPATH

As far as I understand, fasttemplate now relies heavily on unsafe for performance optimizations.
How could we workaround this so that fasttemplate and echo stay compatible with GAE ?

@etnbrd etnbrd referenced this issue in labstack/echo Jan 16, 2017

Closed

[URGENT] Echo GAE problems #824

3 of 3 tasks complete
@hkoske

This comment has been minimized.

Show comment
Hide comment
@hkoske

hkoske Jan 17, 2017

@valyala having the same issue.

hkoske commented Jan 17, 2017

@valyala having the same issue.

@dhanunjay

This comment has been minimized.

Show comment
Hide comment
@dhanunjay

dhanunjay Jan 31, 2017

@valyala I am also hit by this bug on GAE. is there any workaround?

@valyala I am also hit by this bug on GAE. is there any workaround?

@ramesh-dev

This comment has been minimized.

Show comment
Hide comment
@ramesh-dev

ramesh-dev Feb 6, 2017

guys, any update on this?

guys, any update on this?

@hkoske

This comment has been minimized.

Show comment
Hide comment
@hkoske

hkoske Feb 20, 2017

@valyala could this PR be merged? It's been open for quite a while now.
This fix is urgently needed

hkoske commented Feb 20, 2017

@valyala could this PR be merged? It's been open for quite a while now.
This fix is urgently needed

@nigeon

This comment has been minimized.

Show comment
Hide comment
@nigeon

nigeon Feb 24, 2017

@valyala having the same issue. Please could the PR be merged?
Thanks.

nigeon commented Feb 24, 2017

@valyala having the same issue. Please could the PR be merged?
Thanks.

@valyala

This comment has been minimized.

Show comment
Hide comment
@valyala

valyala Feb 24, 2017

Owner

Merged the PR #4 that fixes the issue.

Owner

valyala commented Feb 24, 2017

Merged the PR #4 that fixes the issue.

@valyala valyala closed this Feb 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment