Shutdown logging - #29
Merged
Merged
Conversation
Collaborator
Author
|
All outputs pre- and post- changes match by md5 hash. |
Collaborator
Author
|
Collaborator
Author
|
Docker pushed to 0.7.5_v.2024-10-03. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the interpreter to version 0.7.4. We added a new script to run regression tests,
run_4x_for_output_regression_test.py, that will run the interpreter 4 times based on passing and not passing inputs and different configuration settings.We also discovered that the logger was writing to the same log when multiple instantiations of the main function were called within the same Python process. So, we revised
moalmanac/logger.pyto create a separate log for each call of the main function, which is the intended behavior.Additions:
moalmanac/logger.pyto shutdown the logger, and added this to the main function ofmoalmanac/moalmanac.py.run_4x_for_output_regression_test.pyto run the run_example.py four times:function_togglesection ofmoalmanac/config.inenabled, and example genomic data fromexample_data/function_togglesection ofmoalmanac/config.inenabled, and no input genomic datafunction_togglesection ofmoalmanac/config.indisabled, and example genomic data fromexample_data/function_togglesection ofmoalmanac/config.indisabled, and no input genomic dataRevisions:
setupfunction ofmoalmanac/logger.py. This allows separate logs to be created if the main function is being called in series within a single python process.Pre-pull request check list,