Updated docker build to support multiple architectures - #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_docker.shwas updated to support multiple architectures. Specifically, we change the bash script to use docker's buildx to build for both linux/amd64 and linux/arm64/v8, which should support most users.Revisions:
build_docker.sh, replaceddocker build -t....withdocker buildx build --platform linux/amd64,linux/arm64/v8 -t...docker pull vanallenlab/moalmanactodocker pull vanallenlab/moalmanac:latestunder the Installation section of the root directory README.No underlying code for either the datasources or method was updated with this pull request. Pushed the new container to vanallenlab/moalmanac:0.8.1.1_v.2024-12-05.
Thank you to @sabrinacamp2 for this recommendation 🙇
Pre-pull request check list,