New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LocalWebMentionStorage is not exported from package
#18
Comments
|
It's an example, available in the codebase for reference but should not be used during implementation. The mongoDB handler is the one I use myself. |
|
In which case, I think the readme should link to the example (as is done later in the readme) and not show an |
|
I guess it could be clearer but non convinced that linking would avoid this confusion. |
|
Perhaps the mongo handler can be used as the example? Right now the readme says: To create instance of the example storage class, the following code can be used.but the code shown can’t be used. This tripped me up as I was getting started, and it's the first line of code shown, so it's a bit of a trip hazard. That said, I’ve been able to get a Webmention endpoint up and running in just a few hours, so thank you for all the work you’ve done on this package so far! |
|
@paulrobertlloyd I understand the reasoning and why that tripped you up. My concern is that I don't want to push people towards using mongoDB. |
* fix(LocalWebMentionStorage): #18 - export LocalWebMentionStorage * test(index): correct test for exports
|
For now, I've exported the example adapter. We can come back to this once we have an idea of how to improve this in a "non-opinionated" way. |
Describe the bug
In the readme, under the Setup heading it is suggested that example storage adapter can be imported as follows:
I’ve corrected a typo in #17 to update the import to reference
LocalWebMentionStorage(capital ‘L’ as it is named in the module), but this function is not exported. It’s unclear from the documentation if this is intended to be exported or not, as later in the readme this function is linked to instead:The text was updated successfully, but these errors were encountered: