Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(readme): Fix Typos and add additional line breaks #17

Merged
merged 1 commit into from Nov 11, 2023

Conversation

paulrobertlloyd
Copy link
Contributor

Spotted a few typos while using this library. Also added some line breaks between paragraphs and headings, and correctly capitalised product names, etc.

@vandie vandie changed the title Update readme.md doc(readme): Fix Typos and add additional line breaks Nov 10, 2023
@vandie
Copy link
Owner

vandie commented Nov 10, 2023

Hey Paul, thanks for the PR. Will review the changes shortly.

Copy link
Owner

@vandie vandie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulrobertlloyd Changes wise, I'm happy. However, your PR doesn't follow the conventional commit rules. Can you please correct this?

https://www.conventionalcommits.org/en/v1.0.0/

readme.md Show resolved Hide resolved
Fix some typos, add line breaks between paragraphs and headings, and correctly capitalise product names, etc.
@paulrobertlloyd
Copy link
Contributor Author

Opps, missed that. Have renamed the commit.

@vandie vandie merged commit 5782c50 into vandie:main Nov 11, 2023
1 check passed
@paulrobertlloyd paulrobertlloyd deleted the patch-1 branch November 11, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants