Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install --production on consuming app missing aws-sdk #15

Closed
codeangler opened this issue Oct 22, 2019 · 1 comment
Milestone

Comments

@codeangler
Copy link

@codeangler codeangler commented Oct 22, 2019

GIVEN that parent applicaiton has aws-param-store in their production dependencies
WHEN running npm install --production
THEN package requires aws-sdk
AND actually it is not present.

proposed solution: have aws-sdk as a dependency.

@richardhyatt

This comment has been minimized.

Copy link
Contributor

@richardhyatt richardhyatt commented Nov 5, 2019

Added aws-sdk as a peer dependency in the 3.1.0 release. It is this way because this library is used with AWS Lambda instances and the sdk is already part of the environment.

@richardhyatt richardhyatt added this to the 3.1.0 milestone Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.