New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External link icon seems stretched #1058

Closed
yaili opened this Issue May 4, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@yaili
Contributor

yaili commented May 4, 2017

1. Bug template

Process

  1. Go to https://docs.vanillaframework.io/en/patterns/links and look at the external icon links

Expected result

The box part of the icon should be squared.

Current result

I'm not 100% sure this is true, but to my naked eye the icon looks slightly distorted, stretched horizontally by maybe 1px.

I can't debug properly because the image file is referenced in a way that it's not easy to, but changing the height to 14px makes it look better, but cropped, which is also not great.

Could someone have a look at this?

@yaili yaili added Priority: Low and removed Priority: Medium labels Jul 6, 2017

@anthonydillon anthonydillon added this to the Iteration 5 milestone Jul 31, 2017

@yaili yaili added Priority: High and removed Priority: Low labels Aug 3, 2017

@anthonydillon anthonydillon removed this from the Iteration 5 milestone Aug 10, 2017

@kwm14 kwm14 added this to the Iteration 6 milestone Aug 22, 2017

@barrymcgee

This comment has been minimized.

Show comment
Hide comment
@barrymcgee

barrymcgee Aug 22, 2017

Member

I think this issue is no longer valid. Since this issue was raised, we have changed how we display this icon, which probably fixed it. When inspecting the icon at normal size, or fully zoomed, it is perfectly and proportionately square.

Screen Shot 2017-08-22 at 15.28.37.png

Screen Shot 2017-08-22 at 15.28.16.png

Member

barrymcgee commented Aug 22, 2017

I think this issue is no longer valid. Since this issue was raised, we have changed how we display this icon, which probably fixed it. When inspecting the icon at normal size, or fully zoomed, it is perfectly and proportionately square.

Screen Shot 2017-08-22 at 15.28.37.png

Screen Shot 2017-08-22 at 15.28.16.png

@barrymcgee

This comment has been minimized.

Show comment
Hide comment
@barrymcgee

barrymcgee Aug 22, 2017

Member

@kwm14 You can view the icon yourself here: https://vanilla-framework.github.io/vanilla-framework/examples/patterns/links/links-external/

Can you review comment above and close this issue if you agree?

Member

barrymcgee commented Aug 22, 2017

@kwm14 You can view the icon yourself here: https://vanilla-framework.github.io/vanilla-framework/examples/patterns/links/links-external/

Can you review comment above and close this issue if you agree?

@kwm14

This comment has been minimized.

Show comment
Hide comment
@kwm14

kwm14 Aug 22, 2017

Contributor

Stretched icon is fixed. Performed same test as Barry normal size and zoomed in to make sure proportion scales.

Closing issue as fix was made in previous release.

Contributor

kwm14 commented Aug 22, 2017

Stretched icon is fixed. Performed same test as Barry normal size and zoomed in to make sure proportion scales.

Closing issue as fix was made in previous release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment