New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.p-heading--icon specifies text color but not background color #1272

Closed
barrymcgee opened this Issue Aug 16, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@barrymcgee
Member

barrymcgee commented Aug 16, 2017

This means when it is used on a strip with a dark background color, text is illegible. This pattern should not specify text color unless it is also specifying a background color.

@barrymcgee barrymcgee self-assigned this Aug 16, 2017

barrymcgee added a commit to barrymcgee/vanilla-framework that referenced this issue Aug 16, 2017

@barrymcgee barrymcgee closed this in #1273 Aug 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment