New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove margin rules on card content #1277

Closed
barrymcgee opened this Issue Aug 18, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@barrymcgee
Member

barrymcgee commented Aug 18, 2017

The card pattern shouldn't affect the spacing of any content within it, as dictated by the spec.

Removing this spacing means that the card footer will also need specific margin-top added.

@barrymcgee barrymcgee self-assigned this Aug 18, 2017

barrymcgee added a commit to barrymcgee/vanilla-framework that referenced this issue Aug 18, 2017

@kwm14 kwm14 added this to the Iteration 6 milestone Aug 22, 2017

anthonydillon added a commit that referenced this issue Aug 22, 2017

Remove card content spacing (#1278)
* Remove card content spacing

Fixes #1277

* Add top margin to card footer

* Remove .p-card__footer styling

* Resolve scss nesting linting error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment