New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2055 merge code examples #2079

Merged
merged 3 commits into from Dec 11, 2018

Conversation

Projects
None yet
4 participants
@deadlight
Copy link
Contributor

deadlight commented Dec 10, 2018

Done

Merged the docs for all code components

QA

  • Pull code
  • cd to /docs
  • Run ./run serve --watch
  • Open http://localhost:8104/en/
  • See that there is only "Code" under the "Text" heading on the page
  • Click the "code" link and view the page

Details

Fixes #2055

@webteam-app

This comment has been minimized.

@Caleb-Ellis
Copy link
Contributor

Caleb-Ellis left a comment

Just some leftover links that should be removed


### Related
See also: [code snippet](/en/patterns/code-snippet).

This comment has been minimized.

@Caleb-Ellis

Caleb-Ellis Dec 11, 2018

Contributor

404


* [Code design](https://github.com/ubuntudesign/vanilla-design/tree/master/Code)
Code numbered extends the [base styling of code](/en/base/code).

This comment has been minimized.

@Caleb-Ellis

Caleb-Ellis Dec 11, 2018

Contributor

This should be removed

@Caleb-Ellis
Copy link
Contributor

Caleb-Ellis left a comment

fully sick m8

@kwm14

This comment has been minimized.

Copy link
Contributor

kwm14 commented Dec 11, 2018

Reviewed at desk with @deadlight 👍

@deadlight deadlight merged commit b40c4d5 into vanilla-framework:develop Dec 11, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
percy/vanilla-framework Visual review automatically approved, no visual changes found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment