Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there any addons in this repo that should be removed? #537

Open
linc opened this Issue Jul 14, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@linc
Copy link
Member

linc commented Jul 14, 2017

@linc linc added this to the 2017-Q3-2 milestone Jul 14, 2017

@linc linc self-assigned this Jul 14, 2017

@R-J

This comment has been minimized.

Copy link
Member

R-J commented Jul 16, 2017

What would be a reason to remove one of the plugins? The only reasons I could think of a plugin is broken or if it serves a purpose which is in core now.

In my opinion if one of the contained addons is broken, it should be fixed. If there is no interest in fixing it, it should still be kept, only added with a note. Maybe later on someone else would fix it. And it could still serve a) as an inspiration and b) as a code example.

@linc

This comment has been minimized.

Copy link
Member Author

linc commented Jul 16, 2017

What would be a reason to remove one of the plugins?

  • Addon has become obsolete by core changes, another addon, or exterior changes. I think the two 'compatibility' addons may fall in this camp, now.
  • Addon is broken and no one cares enough to fix it. I suspect Mollom falls in this category.
  • Addon has issues that are not resolvable or experience has taught us it wasn't as good an idea as we thought. Example: CustomizeText, Whispers.

And it could still serve a) as an inspiration and b) as a code example.

Dead code should be used for neither, IMO. Our ecosystem is already littered with examples that are the opposite of a good idea and/or full of illegible code. Our examples should be our best curated work, not the junk heap.

@charrondev

This comment has been minimized.

Copy link
Contributor

charrondev commented Jul 24, 2017

@linc Hasn't NBBC been rolled into core?

@charrondev

This comment has been minimized.

Copy link
Contributor

charrondev commented Jul 24, 2017

Reactions Stub is broken at the moment. It's purpose was to similulate the html structure of look of the proprietary Reactions plugin for theming purposes by people that used the hosted services but did not have access to the internal repositories. It has fallen out of sync with the actually reactions plugin by a good bit now, so no longer successully fulfills that purpose.

I'm not sure how many people were using it for this, but I don't think its that many considering it doesn't work properly anymore. Right no it actually does more harm than good sitting in this repo (Someone can come along and theme that markup, that no longer resembes the markup of the real plugin). We should update it or remove it.

@DaazKu

This comment has been minimized.

Copy link
Member

DaazKu commented Jul 25, 2017

NBBC has been rolled into core, yes.

@linc linc modified the milestones: 2017-Q3-3, 2017-Q3-2 Jul 30, 2017

@linc linc modified the milestones: 2017-Q3-4, 2017-Q3-3 Aug 11, 2017

@linc linc modified the milestones: 2017-Q3-5, 2017-Q3-4 Aug 28, 2017

@linc linc modified the milestones: 2017-Q3-5, 2017-Q4-1 Sep 18, 2017

@linc linc modified the milestones: 2017-Q4-1, 2017-Q4-2 Oct 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.