From 9dc6b2bb81342422da720d9d81d1b2696058d572 Mon Sep 17 00:00:00 2001 From: Austin S Date: Sat, 26 Dec 2015 05:48:00 -0800 Subject: [PATCH] Ensure $Discussion is passed by reference `$Discussion ` is not passed by reference all the way through the calls beginning from the `getWhere()` method; the discussion data cannot be modified from the `SetCalculatedFields` event when the `getWhere()` method is used when it should be able to. --- applications/vanilla/models/class.discussionmodel.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/applications/vanilla/models/class.discussionmodel.php b/applications/vanilla/models/class.discussionmodel.php index fbfb19d382d..dabd0a0629e 100644 --- a/applications/vanilla/models/class.discussionmodel.php +++ b/applications/vanilla/models/class.discussionmodel.php @@ -736,7 +736,7 @@ public function calculate(&$Discussion) { $Discussion->LastDate = $Discussion->DateInserted; } - $this->EventArguments['Discussion'] = $Discussion; + $this->EventArguments['Discussion'] = &$Discussion; $this->fireEvent('SetCalculatedFields'); }