…tually read code.
Event names should communicate in which state of a process they are. So "BeforeDeleteComment" is clear while "DeleteComment" is not determined. I suggest to make "DeleteComment" deprecated as of version 2.somethinginthefuture.
This issue manifested itself when Garden.SSO.SyncRoles was turned on and then a new user was registered via embedded SSO. In this case the new user would have no roles rather than those passed via the SSO.
Since methods named “permission” have been forced internal with the Gdn_Controlle->internalMethods home/permission now comes up as a 404. Furthermore, the permission method should never have been overridden with an incompatible implementation anyway.