Dashboard stats displaying re-framed inside itself #1400

Closed
pokrface opened this Issue Jul 23, 2012 · 5 comments

Projects

None yet

2 participants

@pokrface

I've had this issue with every version of 2.1 that I've tried since April, including a current git pull of 2.1a23 from the master branch. When the Vanilla Statistics plugin (version 2.0.2, again all from a current pull from master) is set to enabled, the dashboard homepage displays a broken version of the statistics graph and then displays the entire dashboard re-framed inside of itself, like so:

http://dl.getdropbox.com/u/33609/Screen%20Shot%202012-07-23%20at%2011.24.27%20AM.png

This occurs in every version of Firefox I have available to try (from 11-14.0.1), Chrome 20.0.1132.57, Safari 5.1.7, Opera 11.62, and IE 9.0.8112.16421. I tested FF & Chrome on Windows 7, Linux, and OS X; Safari on OS X only, and Opera & IE on Windows 7 only.

Rapidly drag-resizing the window causes additional strange behavior, with the date in the lower frame flickering back and forth to several locations; there is also high CPU usage (I'm guessing because of the graph trying to re-draw as the screen resizes) and sometimes I can get the bottom frame to vanish and everything to appear correctly with no reframing, though only for a moment. There seems to be no pattern to it--the momentary bouts of "correct" behavior don't appear to be tied to a certain window shape or size.

I am using a custom theme (a variant of Bittersweet) for the forum, but I have not reskinned the Dashboard or any of its associated views.

The actual functionality of the forum is unaffected, but I've been without the use of the Statistics add-on since updating to 2.1. I know 2.1 is prerelease, but has this issue appeared for anyone else?

@refringe
Contributor

I'm experiencing this with Vanilla Version 2.0.18.4.
http://cdn.vanillaforums.com/www.vanillaforums.org/FileUpload/3c/b3f6183562d4ff5101b04b939b75db.png

It may have something to do with a rewrite rule, because when I set $Configuration['Garden']['RewriteUrls'] to FALSE it goes back to working normally.

I'm using Nginx and a slight variation of this config:
http://blog.bigdinosaur.org/vanilla-forum-on-nginx/

When taking a look at the source with Firebug I can see after the VanillaStatsGraph iframe tag there's a div with a class of DashboardSummaries that has the entire dashboard loaded within it, including the title tag, link tags, but not the scripts. Very odd.

@refringe
Contributor

This is the offending line:
https://github.com/vanillaforums/Garden/blob/master/plugins/VanillaStats/js/vanillastats.js#L42

This URL is returning the entire dashboard:
/dashboard/settings/dashboardsummaries&DeliveryType=VIEW&Range=day&DateRange=July 24, 2012 - July 30, 2012

And this URL is returning just the stats summary, as it should:
/index.php?p=/dashboard/settings/dashboardsummaries&DeliveryType=VIEW&Range=day&DateRange=July 24, 2012 - July 30, 2012

@pokrface

Thanks, refringe :D

@pokrface pokrface closed this Aug 3, 2012
@pokrface
pokrface commented Aug 3, 2012

Confirmed that the code in Refringe's pull request fixes the issue. Hooray!

@refringe
Contributor
refringe commented Aug 3, 2012

It's a temporary fix for the issue; it doesn't solve the cause of the problem. I still don't know why the URL without the index.php is returning the entire template. I don't think it should. I'm not familiar enough with the internals of Vanilla yet, so someone else may have to answer that. You may want to re-open the issue in the meantime.

@linc linc added a commit that referenced this issue Aug 3, 2012
@refringe @linc refringe + linc Updated Dashboard Summaries URL For Nginx
The Dashboard Summaries URL has been updated to include "/index.php?p=". This allows you to use the Nginx try_files/rewrite functionality without issue. Fix for issue #1400.
e322471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment