Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify upgrades: notice to delete removed files if they still exist #2518

Closed
linc opened this Issue Feb 22, 2015 · 11 comments

Comments

Projects
None yet
7 participants
@linc
Copy link
Member

linc commented Feb 22, 2015

Our upgrade process for open source is "copy these new files over" but every once in a while, we remove a file that can cause problems with that methodology, like the helper_functions.php in the default mobile theme, or the default.master.php when we went to .tpl. What do we think of adding some basic file deletion to the Dashboard's Structure to nuke those files so we can simplify upgrade instructions?

My only concern would be if someone has hacked those files, but I kinda feel like you voided your warranty in that situation.


The consensus appears to be adding a notice that prompts you to delete them yourself.

@linc linc added the Enhancement label Feb 22, 2015

@linc linc added this to the 2.2 beta milestone Feb 22, 2015

@R-J

This comment has been minimized.

Copy link
Member

R-J commented Feb 22, 2015

In general: if it is okay for me that all my files are overwritten, it should be okay that some files vanish altogether. But I'd prefer to replace its contents with a short comment

<?php
// this file is not needed from version x.y onwards
@linc

This comment has been minimized.

Copy link
Member Author

linc commented Feb 22, 2015

@R-J That would defeat the point and further break sites. The files need to be deleted because of view overriding.

@x00

This comment has been minimized.

Copy link
Contributor

x00 commented Feb 23, 2015

I don't think so.

I think you can tell people to delete files, but that is as far as it should go.

Once you you are in the business of file management, that is a lot of responsibly on your shoulders. It has consequences such as requiring permission over the files.

I think Install/Upgrade should be about guiding people.

If it worked differently, and you were producing a client program for updates an addons, that is one thing becuase it ti not part of web application itself, it is a tool for server management of the framework.

@chanhong

This comment has been minimized.

Copy link
Contributor

chanhong commented Feb 23, 2015

Is it possible to rename or move the file to be deleted and replace it with a holder file with info about the action so that the user have a way to trace back to figure out what to do.

@x00

This comment has been minimized.

Copy link
Contributor

x00 commented Feb 23, 2015

@chanhong I don't really see the point. What webmaster gives permission to a webapp to do that sort of thing anyway?

@x00

This comment has been minimized.

Copy link
Contributor

x00 commented Feb 23, 2015

Don't use a sledgehammer to crush a nut. This is a minor inconvience.

@chanhong

This comment has been minimized.

Copy link
Contributor

chanhong commented Feb 23, 2015

ok, then just show in the install instruction that which file to be deleted so that they will have a chance to backup the file themselves and decide what to do with it.

@x00

This comment has been minimized.

Copy link
Contributor

x00 commented Feb 23, 2015

general feedback mechanism in install/upgrade +1

@hgtonight

This comment has been minimized.

Copy link
Contributor

hgtonight commented Feb 23, 2015

Hmm... I don't like the idea of automatically deleting files.

Perhaps an inform message on admin pages saying a file that should be deleted exists would be better? Basically a dismissible message that is inserted in the structure phase?

@adrianspeyer

This comment has been minimized.

Copy link
Member

adrianspeyer commented Feb 23, 2015

I agree with @hgtonight, make it clear: "Hey this file should be removed" maybe part of the utility structure phase?

@linc

This comment has been minimized.

Copy link
Member Author

linc commented Feb 27, 2015

I like the message idea & will amend the issue to reflect that.

@linc linc changed the title Simplify upgrades: auto-delete removed files Simplify upgrades: notice to delete removed files if they still exist Feb 27, 2015

@linc linc removed this from the 2.2 beta milestone Jun 3, 2015

@linc linc removed the Enhancement label Jun 4, 2015

@linc linc modified the milestones: 2017-Q1-6, 2017-Q1-4 Jan 29, 2017

beckyvb added a commit that referenced this issue Feb 17, 2017

Check for the existence of deleted files at /utility/upgrade endpoint
Informs users of files that exist in their installation that have been deleted since the last release.

Closes #2518
Closes #5086

@linc linc closed this Mar 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.