Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BMPs result in "file failed to upload" error w/ Advanced Editor #2846

Closed
JulieVanilla opened this issue Jun 18, 2015 · 7 comments
Closed

BMPs result in "file failed to upload" error w/ Advanced Editor #2846

JulieVanilla opened this issue Jun 18, 2015 · 7 comments
Assignees
Milestone

Comments

@JulieVanilla
Copy link

Attempting to upload a BMP file with the Advanced Editor, even when it's specifically whitelisted, results in receiving a "file failed to upload" error.

Expected result: BMP is attached without issue.

@JulieVanilla
Copy link
Author

Should have sprinted label.

@linc
Copy link
Contributor

linc commented Jun 18, 2015

Did you try both the "select file" and drag & drop?

@linc linc added the Sprinted label Jun 18, 2015
@JulieVanilla
Copy link
Author

Confirmed that neither select file nor drag & drop works. Both throw the file failed to upload error.

@linc linc removed the Sprinted label Nov 21, 2015
@linc linc added this to the sprint 001 milestone Nov 21, 2015
@linc linc modified the milestones: sprint 001, sprint 005 Feb 8, 2016
@linc linc modified the milestones: sprint 005, sprint 006 Feb 22, 2016
@initvector
Copy link
Contributor

There's nothing currently in Vanilla for handling bitmap uploads. This is because PHP doesn't have the native ability to handle bitmap files. It supports WBMP (wireless bitmaps), but not the BMP we all know and love. I don't think there's any real way to make this happen without bringing in a third-party image library or investing significant time into making our own.

I vote we just leave BMPs in the past, where they belong.

@linc
Copy link
Contributor

linc commented Mar 10, 2016

@initvector I don't think the goal here is to allow them as image uploads that embed or render, but rather to just make them an attachment, like a ZIP or PDF.

@JulieVanilla
Copy link
Author

Confirming the desired action is to allow them to be attached, not necessarily rendered.

@initvector
Copy link
Contributor

That makes perfect sense to me! PR for that very thing is pending review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants