Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Notification sends wrong message when post includes a mention #2871

Closed
linc opened this issue Jul 2, 2015 · 0 comments
Closed

Advanced Notification sends wrong message when post includes a mention #2871

linc opened this issue Jul 2, 2015 · 0 comments
Milestone

Comments

@linc
Copy link
Member

@linc linc commented Jul 2, 2015

When someone is mentioned in an OP, the advanced notification of new post in a category sends out mention notifications instead of new post notifications.

Possibly related to closed issue #1292 ?

linc added a commit that referenced this issue Aug 3, 2015
Solves issue: #2871

Notifications for new discussions with advanced notifications were done wrong: at first the HeadlineFormat.Discussion was set to $Activity['HeadlineFormat'], then it was checked if users were mentioned and were to be informed. If yes,  $Activity['HeadlineFormat'] was set to HeadlineFormat.Mention. At last the users with advanced notification were notified but with the last HeadlineFormat.

Simply changing the order to first inform the users with advaanced notification before changing the HeadlineFormat solved the problem.
@linc linc closed this Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.