Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to open plugin settings when Vanilla is in a subdirectory #5273

Closed
lazlo-bonin opened this Issue Mar 2, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@lazlo-bonin
Copy link

lazlo-bonin commented Mar 2, 2017

When trying to open a settings panel in the new dashboard, a 404 error is returned from the notification ajax in the bottom right corner. Looking at my Nginx access logs, I see that the request is attempted at the root (ex.: GET /settings/oauth2?DeliveryType=VIEW&DeliveryMethod=JSON) whereas other requests are taking into account the subdirectory (ex.: GET /forum/utility/getfeed/news/5/extended HTTP/1.1). The correct request should have been GET /forum/settings/oauth2?DeliveryType=VIEW&DeliveryMethod=JSON

I'm not familiar with the source, but I guess the part where the site URL gets added is missing somewhere in the new panel GUI.

@lazlo-bonin

This comment has been minimized.

Copy link
Author

lazlo-bonin commented Mar 2, 2017

Found the fix: in applications/dashboard/settings/helper_functions.php line 164, replace:

$media->addButton(dashboardSymbol('settings'), $settingsUrl, $attr);

with:

$media->addButton(dashboardSymbol('settings'), url($settingsUrl), $attr);

@R-J

This comment has been minimized.

Copy link
Member

R-J commented Jul 17, 2017

Has been fixed with ba21947

@R-J R-J closed this Jul 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.