New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 2. Allow to disable CanonicalUrl in head (badly hit for seo) #1045

Merged
merged 1 commit into from Sep 16, 2011

Conversation

Projects
None yet
2 participants
@iamthes
Contributor

iamthes commented Jul 30, 2011

No description provided.

@linc

This comment has been minimized.

Show comment
Hide comment
@linc

linc Jul 30, 2011

Member

I thought CanonicalUrl was for SEO.

Member

linc commented Jul 30, 2011

I thought CanonicalUrl was for SEO.

@iamthes

This comment has been minimized.

Show comment
Hide comment
@iamthes

iamthes Jul 30, 2011

Contributor

In reality canonical url badly affects on our site.

  1. Some f_cking crawlers scans site pages put results on own pages with canonical url.
  2. Search bots (Google, Yandex) scans pages of f_cking crawlers results
  3. Result is duplicated pages of our site in search results: example.com/page1/ and example.com/application/controller/method (this is very bad for seo)

Our seo promote company VERY recommends remove it.

Contributor

iamthes commented Jul 30, 2011

In reality canonical url badly affects on our site.

  1. Some f_cking crawlers scans site pages put results on own pages with canonical url.
  2. Search bots (Google, Yandex) scans pages of f_cking crawlers results
  3. Result is duplicated pages of our site in search results: example.com/page1/ and example.com/application/controller/method (this is very bad for seo)

Our seo promote company VERY recommends remove it.

@linc

This comment has been minimized.

Show comment
Hide comment
@linc

linc Sep 16, 2011

Member

So you know, we're still discussing this internally and haven't made a final decision about how to best deal with this.

Member

linc commented Sep 16, 2011

So you know, we're still discussing this internally and haven't made a final decision about how to best deal with this.

@linc

This comment has been minimized.

Show comment
Hide comment
@linc

linc Sep 16, 2011

Member

I'll pull this in. However, it's better practice to always provide a default config value explicitly so it's easier to read the code (yes I know it will default to FALSE, but it's not immediately apparent from this line).

Member

linc commented Sep 16, 2011

I'll pull this in. However, it's better practice to always provide a default config value explicitly so it's easier to read the code (yes I know it will default to FALSE, but it's not immediately apparent from this line).

linc added a commit that referenced this pull request Sep 16, 2011

Merge pull request #1045 from iamthes/patch-2
Allow disabling CanonicalUrl in head with config.

@linc linc merged commit 4194df6 into vanilla:unstable Sep 16, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment