Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove application namespaces #3318

Closed
wants to merge 13 commits into from
Closed

Remove application namespaces #3318

wants to merge 13 commits into from

Conversation

linc
Copy link
Contributor

@linc linc commented Nov 21, 2015

Merge before evaluating: #3317

Co-requisite: https://github.com/vanilla/internal/pull/321

Related:

This is a prerequisite for refactoring the dispatcher for API v2.

  • Remove Vanilla app's SettingsController, refactoring its contents into its hooks file.
  • Remove the dashboard/ and vanilla/ URL & menu namespaces.

QA points to consider:

  • ResolvedPath's construction has changed, which effects the view counter for discussions.
  • Dashboard's category management system was most heavily effected.
  • Category API endpoints must continue working as documented. (Also note that /category/get is undocumented but must be tested)
  • 'Advanced' page was effected.
  • 'Flood Control' page was heavily refactored.
  • Many miscellaneous menu navigation items were effected.
  • When altering menu & URL items, I left starting/training slashes as-is except where a nearby parallel example contradicted the pattern (e.g. 2 menu items in a row, one with a starting slash and the other without).

@linc linc added Status: WIP This pull request is currently in progress. Do NOT merge it. Status: Hold Do NOT merge this Pull Request. labels Nov 21, 2015
@linc linc changed the title Refactor Vanilla's settingscontroller into oblivion Refactor away application namespaces Nov 21, 2015
@linc linc removed the Status: WIP This pull request is currently in progress. Do NOT merge it. label Nov 21, 2015
@linc linc changed the title Refactor away application namespaces Remove application namespaces Nov 21, 2015
@linc linc added Status: Hold Do NOT merge this Pull Request. and removed Status: Hold Do NOT merge this Pull Request. labels Nov 21, 2015
@linc linc added Awaiting Feedback and removed Status: Hold Do NOT merge this Pull Request. labels Dec 7, 2015
@linc linc closed this Dec 7, 2015
@linc linc deleted the refactor/settings branch January 4, 2016 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants