Drop attribute "type" for style tags #4804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vanilla uses html5 and in html5 the default type is "text/css". Based on [that information](http://www.w3schools.com/tags/att_style_type.asp), this type is the only supported type anyway. So even if browsers wouldn't be compatible with html5, they would treat a simple `<style>` tag correctly.
beckyvb
suggested changes
Dec 5, 2016
| @@ -192,7 +192,7 @@ | |||
| </style> | |||
| <!--[if (gte mso 9)|(IE)]> | |||
| [[literal]] | |||
| <style type="text/css"> | |||
| <style> | |||
There was a problem hiding this comment.
Some email clients are not yet HTML5 compliant, so I don't feel comfortable removing this yet.
| @@ -6,7 +6,7 @@ | |||
| <!--<![endif]--><meta name="viewport" content="width=device-width, initial-scale=1.0"> | |||
| <!--[if (gte mso 9)|(IE)]> | |||
| {literal} | |||
| <style type="text/css"> | |||
| <style> | |||
There was a problem hiding this comment.
Some email clients are not yet HTML5 compliant, so I don't feel comfortable removing this yet.
|
Mail templates now have the type attribute again |
beckyvb
reviewed
Dec 7, 2016
| @@ -6,7 +6,7 @@ | |||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | |||
| <!--<![endif]--> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | |||
| <style> | |||
| <style type="text/css"> | |||
There was a problem hiding this comment.
This one isn't necessary. This file gets compiled into a Smarty template (email/email-basic.tpl) where this block of css gets inlined and the block disappears. The email/email-basic.tpl file is the actual email template that gets used.
beckyvb
approved these changes
Jan 3, 2017
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vanilla uses html5 and in html5 the default type is "text/css". Based on that information, this type is the only supported type anyway. So even if browsers wouldn't be compatible with html5, they would treat a simple
<style>tag correctly.