Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add body to comment and discussion notifications #9412

Merged

Conversation

@initvector
Copy link
Contributor

@initvector initvector commented Oct 17, 2019

Vanilla supports including post contents in comment and discussion notifications. This is currently optional, but moving forward with improvements to notifications, this will be required to give adequate context for email notifications.

Merging into a feature branch for batching email notifications.

Closes #9309

Copy link
Member

@nervoustwit nervoustwit left a comment

Tested locally.

@initvector initvector merged commit 7f30bdf into feature/notifications-batch-email Oct 17, 2019
13 checks passed
13 checks passed
ci/chromatic 26 stories unchanged.
Details
ci/circleci: frontend_build Your tests passed on CircleCI!
Details
ci/circleci: frontend_lint Your tests passed on CircleCI!
Details
ci/circleci: frontend_setup Your tests passed on CircleCI!
Details
ci/circleci: frontend_test Your tests passed on CircleCI!
Details
ci/circleci: frontend_typechecker Your tests passed on CircleCI!
Details
ci/circleci: php_72_integration Your tests passed on CircleCI!
Details
ci/circleci: php_72_lint Your tests passed on CircleCI!
Details
ci/circleci: php_72_tests Your tests passed on CircleCI!
Details
ci/circleci: php_setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
commit Workflow: commit
Details
license/cla Contributor License Agreement is signed.
Details
@initvector initvector deleted the feature/post-notification-body branch Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.