Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to AndroidX #56

Merged
merged 5 commits into from
Nov 10, 2018
Merged

Migrate to AndroidX #56

merged 5 commits into from
Nov 10, 2018

Conversation

JvmName
Copy link
Contributor

@JvmName JvmName commented Nov 9, 2018 •
edited
Loading

  • changed compileSDK to 28
  • updated support deps and test deps to the AndroidX equivalents
  • added AndroidX + Jetifier flags to gradle.properties

@JvmName
Copy link
Contributor Author

JvmName commented Nov 9, 2018

PS I ran all the tests and they passed - let's see if TravisCI agrees ^_^

@codecov
Copy link

codecov bot commented Nov 9, 2018 •
edited
Loading

Codecov Report

Merging #56 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #56   +/-   ##
======================================
  Coverage    63.9%   63.9%           
======================================
  Files           5       5           
  Lines         133     133           
  Branches       19      19           
======================================
  Hits           85      85           
  Misses         43      43           
  Partials        5       5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 354fce9...15657bd. Read the comment docs.

vanniktech
vanniktech reviewed Nov 10, 2018
View reviewed changes
Copy link
Owner

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got some questions. Thanks for starting this!

build.gradle Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
gradle.properties Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
JvmName
JvmName commented Nov 10, 2018
View reviewed changes
Copy link
Contributor Author

@JvmName JvmName left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've addressed everything -- lemme know!

build.gradle Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
gradle.properties Outdated Show resolved Hide resolved
@vanniktech vanniktech merged commit 058c8f7 into vanniktech:master Nov 10, 2018
@JvmName JvmName deleted the androidx branch November 10, 2018 18:35
@JvmName JvmName mentioned this pull request Sep 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanniktech vanniktech vanniktech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JvmName @vanniktech