New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where should I place customizations? #43

Closed
akidee opened this Issue Sep 17, 2017 · 13 comments

Comments

3 participants
@akidee

akidee commented Sep 17, 2017

Top-level build file:

buildscript {
    repositories {
        jcenter()
        mavenCentral() // retrolambda
    }
    dependencies {

        // retrolambda: https://github.com/evant/gradle-retrolambda
        classpath 'com.android.tools.build:gradle:2.3.3'
        classpath 'me.tatarka:gradle-retrolambda:3.6.1'
        // / retrolambda
    }
}

allprojects {
    repositories {
        jcenter()
        mavenCentral() // retrolambda
    }
}

Sub-project build file:

apply plugin: 'com.android.library'

android {
    compileSdkVersion 25
    buildToolsVersion "25.0.0"

    defaultConfig {
        minSdkVersion 9
        targetSdkVersion 25
        versionCode 1
        versionName ""
    }
    compileOptions {
        sourceCompatibility JavaVersion.VERSION_1_8
        targetCompatibility JavaVersion.VERSION_1_8
    }
    buildTypes {
        debug {
            debuggable true
            minifyEnabled false
            useProguard false
            shrinkResources false
        }
        release {
            useProguard false
            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
        }
    }
}

dependencies {
    compile project(':subproject1')
    compile project(':subproject2')
    compile project(':subproject3')

    ...
    testCompile 'junit:junit:4.12'
}

// retrolambda
apply plugin: 'me.tatarka.retrolambda'
// / retrolambda


buildscript {
    repositories {
        mavenCentral()
    }
    dependencies {
        classpath 'com.vanniktech:gradle-android-javadoc-plugin:0.2.1'
    }
}

apply plugin: 'com.vanniktech.android.javadoc'

androidJavadoc {  // line 69
    
}

Result:

With the androidJavadoc{} block, I get this error:

Error:(69, 0) Could not find method androidJavadoc() for arguments [akandroid_camera_6b8pdnwrdr764xdy7601utnpz$_run_closure3@71857546] on project ':akandroid_camera' of type org.gradle.api.Project.

I have placed androidJavadoc{} into different blocks, but I always get this error. Where must it be placed to make it work?

@vanniktech

This comment has been minimized.

Show comment
Hide comment
@vanniktech

vanniktech Sep 17, 2017

Owner

Place it after the apply plugin

Owner

vanniktech commented Sep 17, 2017

Place it after the apply plugin

@akidee

This comment has been minimized.

Show comment
Hide comment
@akidee

akidee Sep 17, 2017

I get the same error where ever I place it. BTW, the default place for Javadoc seems to be projectdir/javaDoc/ .

akidee commented Sep 17, 2017

I get the same error where ever I place it. BTW, the default place for Javadoc seems to be projectdir/javaDoc/ .

@vanniktech

This comment has been minimized.

Show comment
Hide comment
@vanniktech

vanniktech Sep 18, 2017

Owner

What's wrong with that destination?

Owner

vanniktech commented Sep 18, 2017

What's wrong with that destination?

@akidee

This comment has been minimized.

Show comment
Hide comment
@akidee

akidee Sep 18, 2017

Its not a big problem, but the JavaDoc should be inside the build dir.
Back to the original problem: The androidJavadoc{} block is not usable for me at all ...

akidee commented Sep 18, 2017

Its not a big problem, but the JavaDoc should be inside the build dir.
Back to the original problem: The androidJavadoc{} block is not usable for me at all ...

@vanniktech

This comment has been minimized.

Show comment
Hide comment
@vanniktech

vanniktech Sep 18, 2017

Owner

I can't reproduce this.

Owner

vanniktech commented Sep 18, 2017

I can't reproduce this.

@akidee

This comment has been minimized.

Show comment
Hide comment
@akidee

akidee Sep 19, 2017

Updated the issue description.

akidee commented Sep 19, 2017

Updated the issue description.

@vanniktech

This comment has been minimized.

Show comment
Hide comment
@vanniktech

vanniktech Sep 30, 2017

Owner

Oh I need to make another release. The README is ahead of the current version 0.2.1. Try using the SNAPSHOT version.

Owner

vanniktech commented Sep 30, 2017

Oh I need to make another release. The README is ahead of the current version 0.2.1. Try using the SNAPSHOT version.

@vanniktech vanniktech closed this Sep 30, 2017

@akidee

This comment has been minimized.

Show comment
Hide comment
@akidee

akidee Sep 30, 2017

Which repository must be added so that the artifact will be found? And how do I add it?

akidee commented Sep 30, 2017

Which repository must be added so that the artifact will be found? And how do I add it?

@vanniktech

This comment has been minimized.

Show comment
Hide comment
@vanniktech

vanniktech Sep 30, 2017

Owner

Snapshot repository. You can Google the link and add it with normal gradle syntax

Owner

vanniktech commented Sep 30, 2017

Snapshot repository. You can Google the link and add it with normal gradle syntax

@tir38

This comment has been minimized.

Show comment
Hide comment
@tir38

tir38 Mar 1, 2018

@vanniktech can you go ahead and make another release? It took me some searching to get here. Or at least update readme?

tir38 commented Mar 1, 2018

@vanniktech can you go ahead and make another release? It took me some searching to get here. Or at least update readme?

@vanniktech

This comment has been minimized.

Show comment
Hide comment
@vanniktech

vanniktech Mar 1, 2018

Owner

Is the plugin working correctly with AGP 3.0?

Owner

vanniktech commented Mar 1, 2018

Is the plugin working correctly with AGP 3.0?

@tir38

This comment has been minimized.

Show comment
Hide comment
@tir38

tir38 Mar 2, 2018

Do you mean is 0.3.0-SNAPSHOT working with AGP 3.0? Aside from #45 then yes I think it is.

tir38 commented Mar 2, 2018

Do you mean is 0.3.0-SNAPSHOT working with AGP 3.0? Aside from #45 then yes I think it is.

@vanniktech

This comment has been minimized.

Show comment
Hide comment
@vanniktech

vanniktech Mar 2, 2018

Owner

Alright cool. I'll try to get some time to make a release / enhance a few other things.

Owner

vanniktech commented Mar 2, 2018

Alright cool. I'll try to get some time to make a release / enhance a few other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment