Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix java classes being skipped in AGP >= 3.4 #166

Merged
merged 1 commit into from Jan 13, 2020

Conversation

@jeppeman
Copy link
Contributor

jeppeman commented Jan 10, 2020

Fixes #162

@jeppeman jeppeman force-pushed the jeppeman:master branch from e31ed20 to f24c747 Jan 10, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #166 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #166   +/-   ##
=========================================
  Coverage     88.06%   88.06%           
  Complexity       43       43           
=========================================
  Files             1        1           
  Lines           176      176           
  Branches         24       24           
=========================================
  Hits            155      155           
  Misses           13       13           
  Partials          8        8
Impacted Files Coverage Δ Complexity Δ
...ktech/android/junit/jacoco/GenerationPlugin.groovy 88.06% <ø> (ø) 43 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5461b09...f24c747. Read the comment docs.

@vanniktech vanniktech requested a review from vRallev Jan 10, 2020
Copy link
Owner

vanniktech left a comment

Looks good on my side. Waiting for a review from @vRallev

@vanniktech vanniktech merged commit 0b2f3d6 into vanniktech:master Jan 13, 2020
2 checks passed
2 checks passed
codecov/project 88.06% remains the same compared to 5461b09
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jeppeman

This comment has been minimized.

Copy link
Contributor Author

jeppeman commented Jan 16, 2020

👍 Can we make a release with this fix?

@vanniktech

This comment has been minimized.

Copy link
Owner

vanniktech commented Jan 16, 2020

Will do this weekend / next week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.