Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix legacy Android setup in mpp projects #350

Merged
merged 1 commit into from May 28, 2022

Conversation

gabrielittner
Copy link
Collaborator

@gabrielittner gabrielittner commented May 27, 2022

This fixes publishing Kotlin Multiplatform projects that apply an Android plugin < 7.1.2. In 0.18.0 and earlier Android publishing was configured in the same when as all other plugins and had lower priority than Kotlin MPP (see here). The changes for the new Android API moved it out of that when. The code path for the new API had a check to not do anything for multiplatform, but the code path for older AGP versions was missing this which resulted in the Kotlin MPP publication being overridden. This restores the 0.18.0 behavior of not calling the Android APIs in a mpp project.

I will separately look at the issue of MPP + AGP >= 7.1.2 (#333)

@gabrielittner gabrielittner requested a review from vanniktech May 27, 2022
Copy link
Owner

@vanniktech vanniktech left a comment

This is hard to test in an integration test right?

@gabrielittner
Copy link
Collaborator Author

gabrielittner commented May 28, 2022

I've added a general MPP + Android integration test in #351

@gabrielittner gabrielittner merged commit 399b0f9 into master May 28, 2022
2 checks passed
@gabrielittner gabrielittner deleted the fix-legacy-android-mpp branch May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants