Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create nexus lazily to avoid an error when properties aren't set #405

Merged
merged 1 commit into from Sep 5, 2022

Conversation

eygraber
Copy link
Contributor

@eygraber eygraber commented Sep 5, 2022

Fixes #381 (comment)

The other way to do it would be to make Nexus (and all subsequent types) take Provider<String> instead of String

Copy link
Collaborator

@gabrielittner gabrielittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why I didn't run into the issue while testing. Thanks for trying out the snapshots and for submitting the fix

@gabrielittner gabrielittner merged commit 5e48420 into vanniktech:master Sep 5, 2022
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

closeAndReleaseRepository fails because publish creates multiple staging repositories
3 participants