New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves error messages when `getaddrinfo()` fails #161

Merged
merged 1 commit into from Feb 14, 2018

Conversation

Projects
None yet
3 participants
@gwynne
Copy link
Contributor

gwynne commented Feb 14, 2018

No description provided.

Handle the various non-standard error codes that can be returned by g…
…etaddrinfo() when throwing error messages, including printing the hostname and port on which binding was attempted.
@Joannis
Copy link
Contributor

Joannis left a comment

That's a big annoyance out of the way, yet again!

@tanner0101 tanner0101 added this to the 3.0.0-beta.3 milestone Feb 14, 2018

@tanner0101 tanner0101 self-assigned this Feb 14, 2018

@tanner0101

This comment has been minimized.

Copy link
Collaborator

tanner0101 commented Feb 14, 2018

Awesome, thank you!

@tanner0101 tanner0101 merged commit f93514d into beta Feb 14, 2018

1 check passed

ci/circleci: linux Your tests passed on CircleCI!
Details

@tanner0101 tanner0101 deleted the feature/better-getaddrinfo-errors branch Feb 14, 2018

@tanner0101 tanner0101 modified the milestones: 3.0.0-beta.3, 3.0.0-beta.2 Feb 14, 2018

@tanner0101 tanner0101 added this to Done in Vapor 3 Feb 19, 2018

@tanner0101 tanner0101 removed this from Done in Vapor 3 Mar 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment