-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to async await #152
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 1, 2023
Closed
* Renamed StripeCurrency to Currency * Updated address * Update expandable to have multiple inits. * Updated charge properties and renamed * Added extension for sending requests using strings * Updated charge routes and charge list.
* Renamed Deleted Object. * Added init for DynamicExpandable * Renamed StripeCustomer * Updated Customer and routes * Fix search path for charges API
Co-authored-by: Andrew Edwards <andrew.edwards@saks.com>
* Disable tests for now. * Added http body extension for data. * Renamed StripeFile. * Updated file and file link routes.
Co-authored-by: Andrew Edwards <andrew.edwards@saks.com>
* Renamed Payment intent * Updated payment intent models. * Updated and added payment intent routes.
gwynne
requested changes
Mar 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some remarks
Co-authored-by: Andrew Edwards <andrew.edwards@saks.com>
Co-authored-by: Andrew Edwards <andrew.edwards@saks.com>
Co-authored-by: Andrew Edwards <andrew.edwards@saks.com>
Co-authored-by: Andrew Edwards <andrew.edwards@saks.com>
Co-authored-by: Andrew Edwards <andrew.edwards@saks.com>
Co-authored-by: Andrew Edwards <andrew.edwards@saks.com>
Co-authored-by: Andrew Edwards <andrew.edwards@saks.com>
Co-authored-by: Andrew Edwards <andrew.edwards@saks.com>
… external accounts. (#199)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a few goals for updating to async await APIs and making certain actions easier to do.
A few key areas of focus:
Async Await
Converting all APIs to use async await which means bumping the swift tools version to 5.7
Modifying headers per request
Before:
After:
Cleaner type names and public initializers
Remove the
Stripe
prefix from resources/models as well as make their inits public.This helps a lot when unit testing to create Stripe types without having to setup a dictionary to use the decoding initializer:
What's Been converted
Core Resources
Payment Methods
Products
Checkout
Billing
Connect
Fraud
Issuing
Terminal
Sigma
Reporting
Identity
Webhooks