New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Crypto #33

Merged
merged 4 commits into from May 7, 2018

Conversation

4 participants
@0xTim
Copy link
Member

0xTim commented Apr 3, 2018

Export Crypto in Authentication so using things like the BCryptDigest for setting up a password verifier don't require an import Crypto

@0xTim 0xTim requested a review from tanner0101 Apr 3, 2018

@Joannis

This comment has been minimized.

Copy link
Member

Joannis commented Apr 3, 2018

You can also export only BCrypt

@0xTim

This comment has been minimized.

Copy link
Member Author

0xTim commented Apr 4, 2018

@Joannis BCrypt isn't its own module now and is inside the Crypto module

@Joannis

This comment has been minimized.

Copy link
Member

Joannis commented Apr 4, 2018

@0xTim I'm aware.
@exported import class Crypto.BCryptHasher would work

@tanner0101

This comment has been minimized.

Copy link
Member

tanner0101 commented Apr 16, 2018

@0xTim this should follow the pattern of other packages and do all exports in a top-level Exports.swift file.

@tanner0101 tanner0101 self-assigned this Apr 16, 2018

@0xTim 0xTim force-pushed the export-crypto branch from 486f6c4 to 2eb0976 May 4, 2018

@0xTim

This comment has been minimized.

Copy link
Member Author

0xTim commented May 4, 2018

@tanner0101 updated

@tanner0101

This comment has been minimized.

Copy link
Member

tanner0101 commented May 7, 2018

thanks!

@tanner0101 tanner0101 merged commit b1d0e08 into master May 7, 2018

1 check failed

ci/circleci: linux Your tests failed on CircleCI
Details
@penny-coin

This comment has been minimized.

Copy link

penny-coin commented May 7, 2018

Hey @0xTim, you just merged a pull request, have a coin!

You now have 6 coins.

@tanner0101 tanner0101 deleted the export-crypto branch May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment