New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CaseIterable protocol for Swift 4.1 #157

Merged
merged 1 commit into from Jun 15, 2018

Conversation

2 participants
@tanner0101
Copy link
Member

tanner0101 commented Jun 6, 2018

This will allow Fluent to take advantage of CaseIterable when it comes in Swift 4.2. Unfortunately the FixedWidthInteger protocol needs to go away because it causes ambiguity issues.

@tanner0101 tanner0101 self-assigned this Jun 6, 2018

@tanner0101 tanner0101 added this to the 3.3.0 milestone Jun 15, 2018

@penny-coin

This comment has been minimized.

Copy link

penny-coin commented Jun 15, 2018

Hey @tanner0101, you just merged a pull request, have a coin!

You now have 707 coins.

@tanner0101 tanner0101 merged commit e8abb26 into master Jun 15, 2018

7 of 9 checks passed

ci/circleci: linux-fluent-postgresql Your tests failed on CircleCI
Details
ci/circleci: linux-fluent-sqlite Your tests failed on CircleCI
Details
ci/circleci: linux Your tests passed on CircleCI!
Details
ci/circleci: linux-fluent-mysql Your tests passed on CircleCI!
Details
ci/circleci: linux-jwt Your tests passed on CircleCI!
Details
ci/circleci: linux-leaf Your tests passed on CircleCI!
Details
ci/circleci: linux-redis Your tests passed on CircleCI!
Details
ci/circleci: linux-release Your tests passed on CircleCI!
Details
ci/circleci: linux-vapor Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment