New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localized error #92

Merged
merged 4 commits into from Feb 20, 2018

Conversation

Projects
None yet
2 participants
@tanner0101
Copy link
Member

tanner0101 commented Feb 20, 2018

  • add localizedDescription support to debuggable errors
  • long awaited cleanup of the debuggable protocols

@tanner0101 tanner0101 self-assigned this Feb 20, 2018

@Andrewangeta

This comment has been minimized.

Copy link
Member

Andrewangeta commented Feb 20, 2018

An example using localizedDescription for tests? Does the protocol somehow map it from errorDescription?

tanner0101 added some commits Feb 20, 2018

@tanner0101 tanner0101 added this to the 3.0.0-beta. milestone Feb 20, 2018

@tanner0101

This comment has been minimized.

Copy link
Member Author

tanner0101 commented Feb 20, 2018

@Andrewangeta yes that seems to be a computed property that the LocalizedError generates.

@Andrewangeta

This comment has been minimized.

Copy link
Member

Andrewangeta commented Feb 20, 2018

Ah alrighty. looks good to me.

@tanner0101 tanner0101 modified the milestones: 3.0.0-beta., 3.0.0-beta.2 Feb 20, 2018

@tanner0101 tanner0101 merged commit 1f64557 into beta Feb 20, 2018

1 check passed

ci/circleci: linux Your tests passed on CircleCI!
Details

@tanner0101 tanner0101 deleted the localized-error branch Feb 20, 2018

@tanner0101 tanner0101 added this to Done in Vapor 3 Feb 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment