Skip to content
This repository has been archived by the owner on Sep 3, 2020. It is now read-only.

Add several more default cipher algorithms and make initialization with an EVP_CIPHER public #60

Merged
merged 3 commits into from May 30, 2018

Conversation

MrMage
Copy link
Contributor

@MrMage MrMage commented May 3, 2018

See #59 for discussion. I have not deprecated any of the existing ciphers without further discussion. Note that the new ciphers are unsafe to use without a 128-bit initialization vector.

Regarding making init(c: UnsafePointer<EVP_CIPHER>) public: I had issues using Cipher(named: "aes-256-cfb") on Linux — the cipher was not found. Using EVP_aes_256_cfb128() worked, however. If this is the case for other ciphers as well, it makes sense to let users pass in any EVP_CIPHER they'd like instead of having to refer to them by name.

@MrMage
Copy link
Contributor Author

MrMage commented May 3, 2018

I'm starting to get the suspicion that AES-CFB is not supported on my Linux base image (Ubuntu 14.04). However, it might be supported (and desired) on other systems, and AES-CBC works even on my system.

@tanner0101 tanner0101 added the enhancement New feature or request label May 7, 2018
@tanner0101 tanner0101 self-assigned this May 7, 2018
@tanner0101
Copy link
Member

I don't have a problem with init(c: UnsafePointer<EVP_CIPHER>) being made public. It's not really worth keeping the fact that this implementation is based on OpenSSL a secret. If we were to ever switch away from OpenSSL, it would be a breaking change anyway.

@tanner0101 tanner0101 modified the milestones: 3.1.2, 3.2.0 May 7, 2018
@tanner0101
Copy link
Member

tanner0101 commented May 15, 2018

@MrMage would you want to add the deprecations for the old ECB code to this PR? As discussed in #59

@MrMage
Copy link
Contributor Author

MrMage commented May 22, 2018

I have added deprecations, comments, and global constants. Please take another look.

@MrMage
Copy link
Contributor Author

MrMage commented May 26, 2018

Friendly ping :-)

Copy link
Member

@tanner0101 tanner0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@penny-coin
Copy link

Hey @MrMage, you just merged a pull request, have a coin!

You now have 7 coins.

@tanner0101 tanner0101 merged commit 38ced8f into master May 30, 2018
@tanner0101 tanner0101 deleted the add-ciphers branch May 30, 2018 00:59
@MrMage MrMage mentioned this pull request May 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Vapor 3
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants