This repository has been archived by the owner on Sep 3, 2020. It is now read-only.
Add several more default cipher algorithms and make initialization with an EVP_CIPHER public #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #59 for discussion. I have not deprecated any of the existing ciphers without further discussion. Note that the new ciphers are unsafe to use without a 128-bit initialization vector.
Regarding making
init(c: UnsafePointer<EVP_CIPHER>)
public: I had issues usingCipher(named: "aes-256-cfb")
on Linux — the cipher was not found. Using EVP_aes_256_cfb128() worked, however. If this is the case for other ciphers as well, it makes sense to let users pass in anyEVP_CIPHER
they'd like instead of having to refer to them by name.