New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil assert in DatabaseConnection.connect(to:) #6

Merged
merged 1 commit into from Feb 12, 2018

Conversation

Projects
None yet
2 participants
@bensyverson
Copy link
Contributor

bensyverson commented Feb 5, 2018

If I'm reading this assert right, the condition should evaluate to true, which in this case means we're ensuring that the database is not nil.

@bensyverson bensyverson changed the title Fixes nil assert in DatabaseConnection.connect(to:) Fix nil assert in DatabaseConnection.connect(to:) Feb 5, 2018

@bensyverson bensyverson referenced this pull request Feb 11, 2018

Closed

Fix assertion #7

@tanner0101 tanner0101 added this to the 1.0.0-beta.2 milestone Feb 12, 2018

@tanner0101 tanner0101 added the bug label Feb 12, 2018

@tanner0101 tanner0101 self-assigned this Feb 12, 2018

@tanner0101 tanner0101 merged commit 408b1d9 into vapor:beta Feb 12, 2018

@tanner0101 tanner0101 added this to Done in Vapor 3 Feb 12, 2018

@bensyverson bensyverson deleted the bensyverson:betafix/connection-assert branch Feb 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment