New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to ensure that a date's millisecond part is persisted. #27

Merged
merged 1 commit into from Mar 13, 2018

Conversation

2 participants
@MrMage
Copy link
Contributor

MrMage commented Mar 13, 2018

@tanner0101 tanner0101 changed the base branch from master to nio Mar 13, 2018

@tanner0101 tanner0101 added this to the 1.0.0-rc.2 milestone Mar 13, 2018

@tanner0101 tanner0101 self-assigned this Mar 13, 2018

@MrMage

This comment has been minimized.

Copy link
Contributor Author

MrMage commented Mar 13, 2018

Is there any CI set up for this, or is CI run only on the fluent repo?

@tanner0101

This comment has been minimized.

Copy link
Member

tanner0101 commented Mar 13, 2018

@MrMage circle CI didn't have the option to build forked pull requests enabled. I've since enabled, but I think you must push another commit to trigger the tests.

@tanner0101 tanner0101 closed this Mar 13, 2018

@tanner0101 tanner0101 reopened this Mar 13, 2018

@tanner0101

This comment has been minimized.

Copy link
Member

tanner0101 commented Mar 13, 2018

Actually, was able to trigger it with the good ol' close and reopen. :)

@tanner0101

This comment has been minimized.

Copy link
Member

tanner0101 commented Mar 13, 2018

Annoying branching stuff, ignore the failing test. Thanks!

@tanner0101 tanner0101 merged commit a6d274e into vapor:nio Mar 13, 2018

1 check failed

ci/circleci: linux Your tests failed on CircleCI
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment