Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema updater create "update" schema type #391

Closed
tanner0101 opened this issue Feb 27, 2018 · 0 comments
Closed

schema updater create "update" schema type #391

tanner0101 opened this issue Feb 27, 2018 · 0 comments
Assignees
@tanner0101
Labels
bug Something isn't working
Projects
Vapor 3
Milestone
3.0.0-rc.2.3

Comments

@tanner0101
Copy link
Member

The schema updater (created with Database.update) is incorrectly creating a .create type schema. This needs to be changed (https://github.com/vapor/fluent/blob/master/Sources/Fluent/Schema/SchemaUpdater.swift#L12).

Additionally, some tests should be added to ensure schema migration is working correctly.
@tanner0101 tanner0101 added the bug Something isn't working label Feb 27, 2018
@tanner0101 tanner0101 self-assigned this Feb 27, 2018
tanner0101 added a commit that referenced this issue Mar 27, 2018
@tanner0101
add action arg to databaseschema init. fixes #391
7862ecc
@tanner0101 tanner0101 added this to the 3.0.0-rc.2.3 milestone Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanner0101 tanner0101

Labels
bug Something isn't working
Projects
No open projects
Vapor 3
  
Awaiting triage
Milestone
3.0.0-rc.2.3
Development

No branches or pull requests
1 participant
@tanner0101