New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grouping several filters with `AND` instead of `OR` #399

Merged
merged 3 commits into from Mar 9, 2018

Conversation

2 participants
@MrMage
Copy link
Contributor

MrMage commented Mar 8, 2018

This bug can have a severe impact — imagine a query like userID = 123 AND string LIKE '%foo%' returning every user's data instead of just the current user's! I think there should really be tests to spot issues like this.

Fix grouping several filters with `AND` instead of `OR`
This bug can have a severe impact — imagine a query like `userID = 123 AND string LIKE '%foo%'` returning *every user's data* instead of just the current users! I think there should really be tests to spot issues like this.

MrMage added a commit to MrMage/fluent that referenced this pull request Mar 8, 2018

Add a test to ensure that `AND` queries actually do an `AND` query
... and not an `OR` query. See vapor#399 for context.

MrMage added some commits Mar 8, 2018

Add a test to ensure that `AND` queries actually do an `AND` query
... and not an `OR` query. See #399 for context.

@tanner0101 tanner0101 changed the base branch from master to nio Mar 9, 2018

@tanner0101 tanner0101 changed the base branch from nio to master Mar 9, 2018

@tanner0101 tanner0101 added this to the 3.0.0-rc.2 milestone Mar 9, 2018

@tanner0101 tanner0101 added the bug label Mar 9, 2018

@tanner0101 tanner0101 self-assigned this Mar 9, 2018

@tanner0101

This comment has been minimized.

Copy link
Member

tanner0101 commented Mar 9, 2018

thanks :)

@tanner0101 tanner0101 merged commit 6cb8bf8 into vapor:master Mar 9, 2018

1 check passed

ci/circleci: linux Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment