Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMade FluentError init method public #408
Conversation
This comment has been minimized.
This comment has been minimized.
@calebkleveter in my case I just needed this error only in tests so I used |
This comment has been minimized.
This comment has been minimized.
I could use that hack, but I was going to use it in model inits: guard let id = model.id else {
throw FluentError(identifier: "noID", reason: "A model must have an ID to be connected to a pivot"
} |
tanner0101
added this to the 3.0.0-rc.2 milestone
Mar 20, 2018
tanner0101
added
the
enhancement
label
Mar 20, 2018
tanner0101
self-assigned this
Mar 20, 2018
This comment has been minimized.
This comment has been minimized.
Agreed, this will be nice for the fluent drivers as well. |
tanner0101
merged commit f3585af
into
vapor:master
Mar 20, 2018
1 check was pending
ci/circleci: linux
Your tests are queued behind your running builds
Details
calebkleveter
deleted the
calebkleveter:public-error-init
branch
Mar 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
calebkleveter commentedMar 19, 2018
No description provided.