New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Timestampable when the models are structs. #445

Merged
merged 3 commits into from Apr 20, 2018

Conversation

2 participants
@ccrazy88
Copy link
Contributor

ccrazy88 commented Apr 11, 2018

Fixes #444.

Use the same strategy, as!, that is used for SoftDeletable.

If there are tests that I can/should add to a different repository, please let me know.

@ccrazy88

This comment has been minimized.

Copy link
Contributor Author

ccrazy88 commented Apr 11, 2018

Oh, I found the FluentBenchmark folder. I will add tests.

Edit: Done!

@ccrazy88 ccrazy88 force-pushed the ccrazy88:patch-1 branch 4 times, most recently from a01d957 to 8e43cf6 Apr 11, 2018

@ccrazy88 ccrazy88 force-pushed the ccrazy88:patch-1 branch from 8e43cf6 to dac4074 Apr 11, 2018

ccrazy88 and others added some commits Apr 11, 2018

Fix Timestampable for value types.
Use the same strategy, `as!`, that is used for `SoftDeletable`.
@tanner0101
Copy link
Member

tanner0101 left a comment

thanks!

@tanner0101 tanner0101 added this to the 3.0.0 milestone Apr 20, 2018

@tanner0101 tanner0101 added the bug label Apr 20, 2018

@tanner0101 tanner0101 self-assigned this Apr 20, 2018

@tanner0101 tanner0101 merged commit d756974 into vapor:master Apr 20, 2018

4 checks passed

ci/circleci: linux Your tests passed on CircleCI!
Details
ci/circleci: linux-mysql Your tests passed on CircleCI!
Details
ci/circleci: linux-postgresql Your tests passed on CircleCI!
Details
ci/circleci: linux-sqlite Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment