Add default implementation for CredentialsAuthenticatable #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwynne
reviewed
Dec 8, 2020
| public let database: DatabaseID? | ||
|
|
||
| func authenticate(credentials: ModelCredentials, for request: Request) -> EventLoopFuture<Void> { | ||
| User.query(on: request.db(self.database)).filter(\._$username == credentials.username).first().flatMapThrowing { foundUser in |
There was a problem hiding this comment.
Maybe, since this is a default implementation that a lot of people will end up using, we should do something like this:
.all()
.flatMapThrowing {
#if DEBUG
assert($0.count <= 1 , "Usernames must be unique in your database")
#else
guard $0.count <= 1 else throw Abort(.conflict, reason: "Found more than one matching user")
#endif
return $0.first
}I'd hate for it to turn into another potential footgun for the unsuspecting 😕. Granted, this would only catch the case where someone actually did end up with multiple of the same username, but at least it's something.
There was a problem hiding this comment.
Given this affects all of the authenticators, we should probably do that as a separate PR
| @@ -99,7 +99,7 @@ private struct DatabaseSessionAuthenticator<User>: SessionAuthenticator | |||
| let databaseID: DatabaseID? | |||
|
|
|||
| func authenticate(sessionID: User.SessionID, for request: Request) -> EventLoopFuture<Void> { | |||
| User.find(sessionID, on: request.db).map { | |||
| User.find(sessionID, on: request.db(self.databaseID)).map { | |||
There was a problem hiding this comment.
Ouch, I don't like that this was missing at all 😕
gwynne
approved these changes
Dec 8, 2020
|
These changes are now available in 4.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the experience for users writing web applications. Adds a
ModelCredentialsAuthenticatorto automatically conformModeltypes toCredentialsAuthenticatableand provide a middleware to use.This can be used when logging in users via a web form, as shown in the tests. This also backfills some tests for ModelSessionAuthenticatable.
Also fixes a bug where the SessionAuthenticator was not using the provided
DatabaseIDResolves #710
Resolves #701
Docs here vapor/docs#576