New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP 418 "I'm a teapot" support to CHTTP #219

Merged
merged 1 commit into from Feb 8, 2018

Conversation

Projects
None yet
3 participants
@JacobSyndeo
Copy link
Contributor

JacobSyndeo commented Feb 6, 2018

Add definition for RFC 2324 I'm a teapot to CHTTP's http_parser.h. This is already supported throughout the rest of Engine, but I noticed that it was missing from here. Given that it's such a critical part of the HTTP spec, we simply can't leave it missing. 馃槣

@JacobSyndeo JacobSyndeo force-pushed the JacobSyndeo:master branch from 2c0a414 to 1f6f170 Feb 6, 2018

@joscdk

This comment has been minimized.

Copy link
Member

joscdk commented Feb 6, 2018

You should have waited until April 1 for this PR 馃槀

@JacobSyndeo

This comment has been minimized.

Copy link
Contributor Author

JacobSyndeo commented Feb 6, 2018

I should've, but I didn't want the miss the chance to have a PR (even a silly one like this) inside of Vapor. 馃榿

@tanner0101

This comment has been minimized.

Copy link
Member

tanner0101 commented Feb 8, 2018

can't believe they didn't support this in CHTTP! @JacobSyndeo can you make this PR against the beta branch as well?

@tanner0101 tanner0101 merged commit f0d3b27 into vapor:master Feb 8, 2018

3 checks passed

ci/circleci: linux Your tests passed on CircleCI!
Details
ci/circleci: linux-3 Your tests passed on CircleCI!
Details
ci/circleci: macos Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment