Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd HTTP 418 "I'm a teapot" support to CHTTP #219
Conversation
JacobSyndeo
force-pushed the
JacobSyndeo:master
branch
from
2c0a414
to
1f6f170
Feb 6, 2018
This comment has been minimized.
This comment has been minimized.
|
You should have waited until April 1 for this PR |
This comment has been minimized.
This comment has been minimized.
|
I should've, but I didn't want the miss the chance to have a PR (even a silly one like this) inside of Vapor. |
This comment has been minimized.
This comment has been minimized.
|
can't believe they didn't support this in CHTTP! @JacobSyndeo can you make this PR against the beta branch as well? |
tanner0101
merged commit f0d3b27
into
vapor:master
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
JacobSyndeo commentedFeb 6, 2018
Add definition for RFC 2324😜
I'm a teapotto CHTTP'shttp_parser.h. This is already supported throughout the rest of Engine, but I noticed that it was missing from here. Given that it's such a critical part of the HTTP spec, we simply can't leave it missing.