New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where larger responses hang [beta.2] #222

Merged
merged 1 commit into from Feb 12, 2018

Conversation

Projects
None yet
2 participants
@kevinup7
Copy link
Contributor

kevinup7 commented Feb 11, 2018

With larger HTTP bodies, the continueBuffer state was not being
handled correctly, causing the last chunk to not be sent.

Fixes vapor/vapor#1492 and probably some others.

Fix issue where larger responses hang
With larger HTTP bodies, the 'continueBuffer' state was not being
handled correctly, causing the last chunk to not be sent.

@tanner0101 tanner0101 added this to the 3.0.0 milestone Feb 12, 2018

@tanner0101 tanner0101 added the bug label Feb 12, 2018

@tanner0101 tanner0101 self-assigned this Feb 12, 2018

@tanner0101

This comment has been minimized.

Copy link
Member

tanner0101 commented Feb 12, 2018

Thanks :) this was it

@tanner0101 tanner0101 merged commit 4965075 into vapor:beta Feb 12, 2018

1 check passed

ci/circleci: linux Your tests passed on CircleCI!
Details

@tanner0101 tanner0101 changed the title Fix issue where larger responses hang Fix issue where larger responses hang [beta.2] Feb 12, 2018

@tanner0101

This comment has been minimized.

Copy link
Member

tanner0101 commented Feb 12, 2018

Failing test case added in #223

@tanner0101 tanner0101 added this to Done in Vapor 3 Feb 12, 2018

@tanner0101 tanner0101 modified the milestones: 3.0.0, 3.0.0-beta.2 Feb 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment