Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V4] Deinitialise correct pointer #158

Merged
merged 1 commit into from
Apr 15, 2024
Merged

[V4] Deinitialise correct pointer #158

merged 1 commit into from
Apr 15, 2024

Conversation

ptoffy
Copy link
Member

@ptoffy ptoffy commented Apr 15, 2024 •
edited
Loading

These changes are now available in 4.13.3

This aims to fix the memory leak reported in #157

gwynne
gwynne approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Surprised that didn't crash.

@ptoffy ptoffy linked an issue Apr 15, 2024 that may be closed by this pull request
Memory leak in 4.13.2 #157
Closed
@ptoffy ptoffy added the semver-patch Internal changes only label Apr 15, 2024
@ptoffy ptoffy merged commit ee06dd4 into v4 Apr 15, 2024
10 of 12 checks passed
@ptoffy ptoffy deleted the fix-memory-leak branch April 15, 2024 08:03
@ptoffy ptoffy mentioned this pull request Apr 15, 2024
Closed
@ptoffy ptoffy changed the title Deinitialise correct pointer [V4] Deinitialise correct pointer Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynne gwynne gwynne approved these changes

@0xTim 0xTim Awaiting requested review from 0xTim 0xTim is a code owner

Assignees
No one assigned
Labels
semver-patch Internal changes only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leak in 4.13.2
2 participants
@ptoffy @gwynne