New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies #82

Merged
merged 4 commits into from Feb 12, 2018

Conversation

Projects
None yet
2 participants
@Cellane
Copy link
Contributor

Cellane commented Feb 12, 2018

No description provided.

Cellane added some commits Feb 12, 2018

@siemensikkema

This comment has been minimized.

Copy link
Member

siemensikkema commented Feb 12, 2018

@Cellane thanks for the PR. The change is 👍 but Circle CI needs to be updated as well to make the checks pass. For reference, see: https://github.com/vapor/vapor/blob/beta/circle.yml.

@Cellane

This comment has been minimized.

Copy link
Contributor Author

Cellane commented Feb 12, 2018

Aha, didn't know it's possible to run your own version of Swift on CircleCI, I'll adjust the configuration file accordingly! It seems I'll have to temporarily disable the macOS tests though (until the final version of Xcode 9.3 with final Swift 4.1 is released), I hope that's fine.

@siemensikkema

This comment has been minimized.

Copy link
Member

siemensikkema commented Feb 12, 2018

I think it's safe to go with whatever is configured for the Vapor package but I have no inside knowledge on that.

Cellane added some commits Feb 12, 2018

@siemensikkema

This comment has been minimized.

Copy link
Member

siemensikkema commented Feb 12, 2018

Thanks!

@siemensikkema siemensikkema merged commit 829ed11 into vapor:beta Feb 12, 2018

1 check passed

ci/circleci: linux Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment