Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdated dependencies #82
Conversation
Cellane
added some commits
Feb 12, 2018
siemensikkema
approved these changes
Feb 12, 2018
This comment has been minimized.
This comment has been minimized.
|
@Cellane thanks for the PR. The change is |
This comment has been minimized.
This comment has been minimized.
|
Aha, didn't know it's possible to run your own version of Swift on CircleCI, I'll adjust the configuration file accordingly! It seems I'll have to temporarily disable the macOS tests though (until the final version of Xcode 9.3 with final Swift 4.1 is released), I hope that's fine. |
This comment has been minimized.
This comment has been minimized.
|
I think it's safe to go with whatever is configured for the Vapor package but I have no inside knowledge on that. |
Cellane
added some commits
Feb 12, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
siemensikkema
merged commit 829ed11
into
vapor:beta
Feb 12, 2018
1 check passed
ci/circleci: linux
Your tests passed on CircleCI!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Cellane commentedFeb 12, 2018
No description provided.