Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment syntax #15

Closed
loganwright opened this issue Jun 6, 2019 · 2 comments
Closed

comment syntax #15

loganwright opened this issue Jun 6, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request
Projects

Comments

@loganwright
Copy link
Member

Original comment syntax of:

        #("foo")
        #// this is a comment!
        bar

and multi-line of:

        #("foo")
        #/*
            this is a comment!
        */
        bar

not currently supported, and conflicts with our new preference of : to open a body and subsequent #end<tag> syntax.

I propose moving to:

#com:
  this is a comment here :)
#endcom
@tanner0101 tanner0101 added the enhancement New feature or request label Jun 8, 2019
@tanner0101 tanner0101 added this to To Do in Vapor 4 via automation Jun 8, 2019
@tdotclare
Copy link
Contributor

I'd really like to introduce commenting for the new syntax, and personally think the solution for readability and function is as simple as this. Tag indicators are not needed inside parameter lists and the observable expectation that an anonymous tag is a passthrough mechanism makes this both easy to parse and easy to read without adding additional characters, complicated rules, or lengthy body closures.

#(# Single Line Comment #)
#(#
Multi Line Comment
#)

@tdotclare
Copy link
Contributor

Closed in LeafKit-1.0.0tau

Vapor 4 automation moved this from Backlog to Done Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Vapor 4
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants