New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .bit & .timestamp, add decode case for .string #131

Merged
merged 3 commits into from Feb 28, 2018

Conversation

2 participants
@PitchLabsAsh
Copy link
Contributor

PitchLabsAsh commented Feb 28, 2018

Why:

MySQL types .bit and .timstamp were not supported

How:

Added case in the parser for .bit by assuming length was never > 1 byte
Added case in the parser for .timestamp using the same parser as .date

@PitchLabsAsh PitchLabsAsh changed the base branch from master to beta Feb 28, 2018

@tanner0101 tanner0101 added this to the 3.0.0-rc.1.1 milestone Feb 28, 2018

@tanner0101 tanner0101 self-assigned this Feb 28, 2018

@tanner0101

This comment has been minimized.

Copy link
Member

tanner0101 commented Feb 28, 2018

Thanks!

@tanner0101 tanner0101 merged commit ceb1d3c into vapor:beta Feb 28, 2018

1 check passed

ci/circleci: linux Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment